brkyvz commented on a change in pull request #25348: [SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348#discussion_r313951437
########## File path: sql/core/src/main/scala/org/apache/spark/sql/sources/v2/writer/V1WriteBuilder.scala ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.sources.v2.writer + +import org.apache.spark.annotation.{Experimental, Unstable} +import org.apache.spark.sql.sources.InsertableRelation + +/** + * A trait that should be implemented by V1 DataSources that would like to leverage the DataSource + * V2 write code paths. The CreatableRelationProvider will be used only to Append data. Other + * instances of the [[WriteBuilder]] interface such as [[SupportsOverwrite]], [[SupportsTruncate]] + * should be extended as well to support additional operations other than data appends. + * + * This interface is designed to provide Spark DataSources time to migrate to DataSource V2 and + * will be removed in a future Spark release. + * + * @since 3.0.0 + */ +@Experimental +@Unstable +trait V1WriteBuilder extends WriteBuilder { Review comment: Hmm, all of the other mixins and their functions return a `WriteBuilder` after their supported operation, whereas this ends the chain. I don't have too strong opinions on this. (I'm also considering, whether this should also finalize unsupported operations for the V2 writes, e.g. `final buildBatchWrite() => Unsupported`) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
