HyukjinKwon commented on a change in pull request #25394: [SPARK-28671][SQL]
Throw NoSuchPermanentFunctionException for a non-exsistent permanent function
in dropFunction
URL: https://github.com/apache/spark/pull/25394#discussion_r314153016
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -1114,7 +1114,7 @@ class SessionCatalog(
}
externalCatalog.dropFunction(db, name.funcName)
} else if (!ignoreIfNotExists) {
- throw new NoSuchFunctionException(db = db, func = identifier.toString)
+ throw new NoSuchPermanentFunctionException(db = db, func =
identifier.toString)
Review comment:
Actually, Catalog-wise, seems the exception makes sense. It's not in temp
and permanent registries. Why don't you just catch the exception and fix it in
the drop command?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
