19kka commented on issue #25450: [SPARK-23793][SQL]Handle database names in 
spark.udf.register()
URL: https://github.com/apache/spark/pull/25450#issuecomment-521537674
 
 
   > Thank you for your first contribution, @19kka . Could you run 
`dev/scalastyle` and fix the errors? I saw some violation like 
[this](https://github.com/apache/spark/pull/25450/files#diff-85fdb913077429ac8e211a3c68375994L24)
 here.
   
   I'm awfully sorry about forget check the style, now I fixed the style error 
and add UDFSuite Test.
   
   I read the related register code again, I realized `spark.sql.resigter()` is 
responsible for  **Create Temp Function** , so I modify the code if 
`spark.sql.resigter()` function name with  **database** name It will throw new 
AnalysisException 
   
   e.g.
   
   ```scala 
   spark.udf.register("db.fun1", (x: Long) => x + 1)
   // throw new AnalysisException
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to