cloud-fan commented on a change in pull request #25348: [SPARK-28554][SQL] Adds
a v1 fallback writer implementation for v2 data source codepaths
URL: https://github.com/apache/spark/pull/25348#discussion_r314397529
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -200,24 +202,37 @@ object DataSourceV2Strategy extends Strategy with
PredicateHelper {
catalog,
ident,
parts,
+ query,
planLater(query),
props,
writeOptions,
orCreate = orCreate) :: Nil
}
case AppendData(r: DataSourceV2Relation, query, _) =>
- AppendDataExec(r.table.asWritable, r.options, planLater(query)) :: Nil
Review comment:
good point on having different physical nodes for different semantics. It
seems to me that the semantic of append is the same between v1 and v2. Shall we
reuse `AppendDataExec`? Then we can make a good story: If semantic is the same,
reuse the v2 plan (CREATE TABLE, CTAS, APPEND). Otherwise, create a new
physical node (OVERWRITE).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
