cloud-fan commented on a change in pull request #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#discussion_r314571122
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala ########## @@ -526,9 +531,9 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product { * @param maxFields Maximum number of fields that will be converted to strings. * Any elements beyond the limit will be dropped. */ - def simpleString(maxFields: Int): String = { - s"$nodeName ${argString(maxFields)}".trim - } + def simpleString(maxFields: Int): String = s"$nodeName ${argString(maxFields)}".trim + + def simpleStringWithNodeId(): String = simpleString(0) Review comment: I'd rather leave it abstract, to make sure it's implemented by `QueryPlan` and we implement `Expression.simpleStringWithNodeId` by throwing exception. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org