cloud-fan commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#issuecomment-521895096 I'm OK to stay with the `TreeNode` string methods for now, but I do think we should refactor it to a visitor pattern in the future. It's more flexible and maintainable. We can put the related code in one place instead of spreading it to many places. BTW I have a concern about subqueries. How do we handle nested subqueries? It looks like the current format will flatten the nested subqueries, and put them all together in the `subqueries` section.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
