Github user lianhuiwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/4134#discussion_r23294907
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -349,34 +349,7 @@ class DAGScheduler(
}
private def getMissingParentStages(stage: Stage): List[Stage] = {
- val missing = new HashSet[Stage]
- val visited = new HashSet[RDD[_]]
- // We are manually maintaining a stack here to prevent
StackOverflowError
- // caused by recursively visiting
- val waitingForVisit = new Stack[RDD[_]]
- def visit(rdd: RDD[_]) {
- if (!visited(rdd)) {
- visited += rdd
- if (getCacheLocs(rdd).contains(Nil)) {
- for (dep <- rdd.dependencies) {
- dep match {
- case shufDep: ShuffleDependency[_, _, _] =>
- val mapStage = getShuffleMapStage(shufDep, stage.jobId)
- if (!mapStage.isAvailable) {
- missing += mapStage
- }
- case narrowDep: NarrowDependency[_] =>
- waitingForVisit.push(narrowDep.rdd)
- }
- }
- }
- }
- }
- waitingForVisit.push(stage.rdd)
- while (!waitingForVisit.isEmpty) {
- visit(waitingForVisit.pop())
- }
- missing.toList
+ stage.parents.filter(s => getCacheLocs(s.rdd).contains(Nil) &&
!s.isAvailable)
--- End diff --
rdd in getMissingParentStages is not always stage's rdd. stage has a
sequence of rdds and stage's rdd is child of stage. if stage's rdd at front of
child rdd is cached, this line cannot filter this stage. but
getMissingParentStages can complete it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
