Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/4123#discussion_r23303748
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala ---
@@ -95,6 +95,10 @@ private[spark] class ClientArguments(args:
Array[String], sparkConf: SparkConf)
throw new IllegalArgumentException(
"You must specify at least 1 executor!\n" + getUsageMessage())
}
+ if (executorCores < sparkConf.getInt("spark.task.cpus", 1)) {
+ throw new SparkException("spark.executor.cores must not be less than
" +
--- End diff --
only nit here is that I might not have specified it via
spark.executor.cores but rather via the spark-submit --executor-cores option.
Perhaps we should just say "Executor cores must".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
