Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/4133#issuecomment-70890584
Can you explain how this fixes the problem? You're changing the order of
the checks, but that doesn't match what the code does. For example, run this in
a Scala shell:
scala> Seq((3L, 2L), (2L, 1L), (-1L, 2L), (-1L, 1L)).sortBy(x =>
(-x._1, -x._2))
res0: Seq[(Long, Long)] = List((3,2), (2,1), (-1,2), (-1,1))
That emulates what `checkForLogs` does in the `sortBy` call (sort first by
end time descending, then by start time descending). As you can see, the entry
with start time `2` should come before the entry with start time `1`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
