srowen commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-522269068 OK, the current state of this change looks correct to me; it is what I would _expect_ the change looks like. It fails because it's not testing vs Hive 2.x. OK if I make the title include `[test-hadoop3.2]`? I think that is the only way it would work. How would we use this in a Jenkins job based on `run-tests`? right now it triggers on the PR title. Same question about `hadoop-3.2` I think. Any mechanism is fine. We can define new profiles if that makes it easier, and key off the existence of a profile. Or env variable. Whatever's standard. With that, we should have the pieces we need. @shaneknapp I am all but sure then that the complex Maven-based job config is simply legacy. I think they should all use the much simpler config seen in SBT-based master builds now. That should already work for Maven right? If in doubt, we can add new Maven-based master builds, ensure they work as desired, and delete the old ones. That would resolve what if anything we need to do to update the Jenkins config to take advantage of changes here for JDK 11 testing. (We can just leave 2.x builds as is) With that I think we have a much cleaner and more robust way to test.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
