srowen commented on a change in pull request #25480: [SPARK-28763][SQL][TEST]
Flaky Tests:
SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V1 get binary
type
URL: https://github.com/apache/spark/pull/25480#discussion_r314959107
##########
File path:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SparkThriftServerProtocolVersionsSuite.scala
##########
@@ -224,7 +224,9 @@ class SparkThriftServerProtocolVersionsSuite extends
HiveThriftJdbcTest {
}
testExecuteStatementWithProtocolVersion(version, "SELECT cast(49960 as
binary)") { rs =>
assert(rs.next())
- assert(rs.getString(1) ===
UTF8String.fromBytes(NumberConverter.toBinary(49960)).toString)
+ assertResult(Array(0, 0, 65533, 40).map(_.toChar)) {
+ rs.getString(1).toCharArray
+ }
Review comment:
@shaneknapp I think we need to standardize `LANG` across the workers? or
should I try giving it shot?
That seems reasonable though I am distantly concerned that something in the
code relies on this setting. That said, I think it's probably correct to set
`LANG` in a prod environment and correct to set it to this value anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
