srowen commented on a change in pull request #25485: [SPARK-28434][TESTS][ML]
Fix values in dummy tree in DecisionTreeSuite
URL: https://github.com/apache/spark/pull/25485#discussion_r314963624
##########
File path:
mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala
##########
@@ -625,8 +620,7 @@ object DecisionTreeSuite extends SparkFunSuite {
assert(a.isLeaf === b.isLeaf)
assert(a.split === b.split)
(a.stats, b.stats) match {
- // TODO: Check other fields besides the information gain.
- case (Some(aStats), Some(bStats)) => assert(aStats.gain === bStats.gain)
+ case (Some(aStats), Some(bStats)) => assert(aStats === bStats)
Review comment:
This is the improved test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
