Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4073#discussion_r23330643
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/mllib/tree/RandomForestSuite.scala ---
    @@ -196,6 +196,24 @@ class RandomForestSuite extends FunSuite with 
MLlibTestSparkContext {
           featureSubsetStrategy = "sqrt", seed = 12345)
         EnsembleTestHelper.validateClassifier(model, arr, 1.0)
       }
    +
    +  test("subsampling rate in RandomForest"){
    +    val arr = EnsembleTestHelper.generateOrderedLabeledPoints(5, 20)
    +    val rdd = sc.parallelize(arr)
    +    val strategy1 = new Strategy(algo = Classification, impurity = Gini, 
maxDepth = 2,
    --- End diff --
    
    I would make 1 instance of strategy, train rf1, modify the strategy's 
subsamplingRate, and train rf2.  Simpler + more clearly using the same settings 
for other parameters


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to