maropu commented on a change in pull request #25461: [SPARK-28741][SQL]Throw
exceptions when casting to integers causes overflow
URL: https://github.com/apache/spark/pull/25461#discussion_r315009217
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -1279,8 +1409,26 @@ case class Cast(child: Expression, dataType: DataType,
timeZoneId: Option[String
(c, evPrim, evNull) => code"$evNull = true;"
case TimestampType =>
(c, evPrim, evNull) => code"$evPrim = (long)
${timestampToIntegerCode(c)};"
+ case DecimalType() if failOnIntegerOverflow =>
+ (c, evPrim, evNull) =>
+ code"""
+ try {
+ $evPrim = $c.toJavaBigInteger().longValueExact();
+ } catch (ArithmeticException e) {
+ throw new ArithmeticException("Casting $c to Long causes
overflow");
+ }
+ """
case DecimalType() =>
(c, evPrim, evNull) => code"$evPrim = $c.toLong();"
+ case _: FloatType | _: DoubleType if failOnIntegerOverflow =>
+ (c, evPrim, evNull) =>
+ code"""
+ if ($c >= ${Long.MinValue}L && $c <= ${Long.MaxValue}L) {
Review comment:
If this is an expected behaivour, its ok to me. pgSQL handles the
out-of-range case and NaN case in the same way:
https://github.com/postgres/postgres/blob/927f34ce8a215c8b254136f710cca9ca4da1352c/src/backend/utils/adt/int8.c#L1269
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
