HeartSaVioR commented on issue #25488: [SPARK-28025][SS] Fix FileContextBasedCheckpointFileManager leaking crc files URL: https://github.com/apache/spark/pull/25488#issuecomment-522379521 Another possible approach would be removing crc file for temp file when FSOutputSummer is being used as OutputStream: ``` underlyingStream match { case e: FSDataOutputStream if e.getWrappedStream.isInstanceOf[FSOutputSummer] => val checksumFile = new Path(tempPath.getParent, s".${tempPath.getName}.crc") fm.delete(checksumFile) case _ => } ``` adding above block after `underlyingStream.close()` would also work. This change will touch RenameBasedFSDataOutputStream.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
