wangyum commented on a change in pull request #24715: [SPARK-25474][SQL] Data 
source tables support fallback to HDFS for size estimation
URL: https://github.com/apache/spark/pull/24715#discussion_r315046331
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
 ##########
 @@ -619,3 +619,34 @@ object DataSourceStrategy {
     (nonconvertiblePredicates ++ unhandledPredicates, pushedFilters, 
handledFilters)
   }
 }
+
+
+/**
+ * Defines default table statistics if table statistics are not available.
+ */
+class DetermineTableStats(session: SparkSession) extends Rule[LogicalPlan] {
+
+  private val conf = session.sessionState.conf
+
+  override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
+    // For the data source table, we only recalculate the table statistics
 
 Review comment:
   How about we only do it when it will use `CatalogFileIndex`?
   ```scala
       case logical @ LogicalRelation(_, _, Some(table), _)
         if DDLUtils.isDatasourceTable(table) && table.stats.isEmpty &&
           conf.fallBackToHdfsForStatsEnabled && 
conf.manageFilesourcePartitions &&
           table.tracksPartitionsInCatalog && 
table.partitionColumnNames.nonEmpty =>
         val sizeInBytes = CommandUtils.getSizeInBytesFallBackToHdfs(session, 
table)
         val withStats = table.copy(stats = Some(CatalogStatistics(sizeInBytes 
= BigInt(sizeInBytes))))
         logical.copy(catalogTable = Some(withStats))
   ```
   
   
https://github.com/apache/spark/blob/5bb69945e4aaf519cd10a5c5083332f618039af0/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala#L382-L391

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to