Github user ksakellis commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4111#discussion_r23333304
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -379,6 +379,41 @@ class SparkContext(config: SparkConf) extends Logging 
with ExecutorAllocationCli
         }
       executorAllocationManager.foreach(_.start())
     
    +  // Use reflection to instantiate listeners specified via the 
`spark.extraListeners` configuration
    --- End diff --
    
    Nit: Can we group this logic with listenerBus.start() into a separate 
method called "setupListenerBus()" and call it in the constructor? The reason 
is this logic has to occur before the listenerBus.start() and having them 
grouped in a method can better ensure the order is preserved. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to