Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/4143#discussion_r23334671
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -46,7 +46,7 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable
with Logging {
/** Create a SparkConf that loads defaults from system properties and
the classpath */
def this() = this(true)
- private[spark] val settings = new HashMap[String, String]()
+ private[spark] val settings = new HashMap[String, String] with
SynchronizedMap[String, String]
--- End diff --
I'd avoid SynchronizedMap:
https://groups.google.com/forum/#!topic/scala-internals/1gCbqTRCxAQ
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
