cloud-fan commented on a change in pull request #25033: [SPARK-28224][SQL]
Check overflow in decimal Sum aggregate
URL: https://github.com/apache/spark/pull/25033#discussion_r315085285
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestData.scala
##########
@@ -91,6 +91,12 @@ private[sql] trait SQLTestData { self =>
df
}
+ protected lazy val largeDecimals: DataFrame = {
Review comment:
`SQLTestData` should only contain data that are widely used by many tests.
Let's move the `largeDecimals` to its test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
