cloud-fan commented on a change in pull request #25235: [SPARK-28483][Core] Fix
canceling a spark job using barrier mode but barrier tasks blocking on
BarrierTaskContext.barrier()
URL: https://github.com/apache/spark/pull/25235#discussion_r315113095
##########
File path: core/src/main/scala/org/apache/spark/rpc/netty/Outbox.scala
##########
@@ -66,14 +66,22 @@ private[netty] case class RpcOutboxMessage(
this.requestId = client.sendRpc(content, this)
}
- def onTimeout(): Unit = {
+ private[netty] def removeRpcRequest(): Unit = {
if (client != null) {
client.removeRpcRequest(requestId)
} else {
- logError("Ask timeout before connecting successfully")
+ logError("Ask terminated before connecting successfully")
}
}
+ def onTimeout(): Unit = {
+ removeRpcRequest()
+ }
+
+ def onAbort(): Unit = {
+ removeRpcRequest()
Review comment:
why don't `onFailure` call `removeRpcRequest`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
