hvanhovell commented on a change in pull request #25491: [SPARK-28699][Core]
Disable using radix sort for ShuffleExchangeExec in repartition case
URL: https://github.com/apache/spark/pull/25491#discussion_r315160934
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
##########
@@ -264,7 +264,7 @@ object ShuffleExchangeExec {
prefixComparator,
prefixComputer,
pageSize,
- canUseRadixSort)
+ false /* canUseRadixSort */)
Review comment:
Ah ok, I did not know that we use binary comparisons. Is this because of Map
not being comparable? If it is, then that might be problematic in itself,
because you expect the retried stage to return map elements in the same order
right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
