cloud-fan commented on a change in pull request #25491: [SPARK-28699][Core]
Disable using radix sort for ShuffleExchangeExec in repartition case
URL: https://github.com/apache/spark/pull/25491#discussion_r315163618
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
##########
@@ -264,7 +264,7 @@ object ShuffleExchangeExec {
prefixComparator,
prefixComputer,
pageSize,
- canUseRadixSort)
+ false /* canUseRadixSort */)
Review comment:
> Is this because of Map not being comparable
Yes, and it's also because we don't have to do an expensive normal sort.
The only problem we want to fix here is inputs with random order. Here we
just want the inputs to have a stable order, but don't really care what the
order is. So comparing via the unsafe row binary format is good enough here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
