mgaido91 commented on a change in pull request #25461: [SPARK-28741][SQL]Throw
exceptions when casting to integers causes overflow
URL: https://github.com/apache/spark/pull/25461#discussion_r315177196
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -1278,9 +1407,27 @@ case class Cast(child: Expression, dataType: DataType,
timeZoneId: Option[String
case DateType =>
(c, evPrim, evNull) => code"$evNull = true;"
case TimestampType =>
- (c, evPrim, evNull) => code"$evPrim = (long)
${timestampToIntegerCode(c)};"
+ (c, evPrim, evNull) => code"$evPrim = (long) ${timestampToLongCode(c)};"
+ case DecimalType() if failOnIntegerOverflow =>
+ (c, evPrim, evNull) =>
+ code"""
+ try {
+ $evPrim = $c.toJavaBigInteger().longValueExact();
Review comment:
this would mean creating several java objects and I don't think it is going
to have good perf. What about using `toLong` with a flag or create a
`toLongExact`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
