zsxwing commented on a change in pull request #23767: [SPARK-26329][CORE]
Faster polling of executor memory metrics.
URL: https://github.com/apache/spark/pull/23767#discussion_r315241915
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -574,7 +600,8 @@ private[spark] class Executor(
logInfo(s"Executor interrupted and killed $taskName (TID $taskId),
reason: $killReason")
val (accums, accUpdates) =
collectAccumulatorsAndResetStatusOnFailure(taskStartTimeNs)
- val serializedTK = ser.serialize(TaskKilled(killReason, accUpdates,
accums))
+ val metricPeaks =
WrappedArray.make(metricsPoller.getTaskMetricPeaks(taskId))
+ val serializedTK = ser.serialize(TaskKilled(killReason, accUpdates,
accums, metricPeaks))
execBackend.statusUpdate(taskId, TaskState.KILLED, serializedTK)
case t: Throwable if hasFetchFailure && !Utils.isFatalError(t) =>
Review comment:
@wypoon Is there any special reason that `metricPeaks` is not send in this
case and `CommitDeniedException`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
