xuanyuanking commented on a change in pull request #25491: [SPARK-28699][Core]
Disable using radix sort for ShuffleExchangeExec in repartition case
URL: https://github.com/apache/spark/pull/25491#discussion_r315249788
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
##########
@@ -264,7 +264,7 @@ object ShuffleExchangeExec {
prefixComparator,
prefixComputer,
pageSize,
- canUseRadixSort)
+ false /* canUseRadixSort */)
Review comment:
Yes, we compare the UnsafeRow binary here, and we the sort here must have a
stable result. Otherwise, it will cause the correctness bug.
Thanks for the advice, add more comments done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
