HeartSaVioR commented on a change in pull request #22282: [SPARK-23539][SS] Add
support for Kafka headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#discussion_r315353038
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala
##########
@@ -498,6 +507,7 @@ private[kafka010] object KafkaSourceProvider extends
Logging {
private[kafka010] val FETCH_OFFSET_RETRY_INTERVAL_MS =
"fetchoffset.retryintervalms"
private[kafka010] val CONSUMER_POLL_TIMEOUT = "kafkaconsumer.polltimeoutms"
private val GROUP_ID_PREFIX = "groupidprefix"
+ private[kafka010] val INCLUDE_HEADERS = "includeHeaders"
Review comment:
nit: This may not a big deal as we always read from case insensitive map,
but I'd feel safer we have consistency here - all lowercase as other
configurations did.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
