rednaxelafx commented on issue #25279: [SPARK-28519][SQL] Use StrictMath log, pow functions for platform independence URL: https://github.com/apache/spark/pull/25279#issuecomment-522758901 I'd like to ask a post-hoc question on this PR: this one focuses on `log()` / `exp()` / `pow()` family of math functions. What about `sqrt()`? You can see that after this PR, there are still code like: ```scala case class Acosh(child: Expression) extends UnaryMathExpression((x: Double) => StrictMath.log(x + math.sqrt(x * x - 1.0)), "ACOSH") { ``` left in mathExpressions.scala, which feels pretty inconsistent. Are we planning to route `sqrt()` to `StrictMath` as well?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
