vanzin commented on a change in pull request #25403: [SPARK-28679][YARN]
changes to setResourceInformation to handle empty resources and reflection
error handling
URL: https://github.com/apache/spark/pull/25403#discussion_r315456091
##########
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceRequestHelper.scala
##########
@@ -143,17 +143,28 @@ private object ResourceRequestHelper extends Logging {
require(resource != null, "Resource parameter should not be null!")
logDebug(s"Custom resources requested: $resources")
+ if (resources.isEmpty) {
+ // no point in going forward, as we don't have anything to set
+ return
+ }
+
if (!isYarnResourceTypesAvailable()) {
- if (resources.nonEmpty) {
- logWarning("Ignoring custom resource requests because " +
- "the version of YARN does not support it!")
- }
+ logWarning("Ignoring custom resource requests because " +
+ "the version of YARN does not support it!")
return
}
val resInfoClass = Utils.classForName(RESOURCE_INFO_CLASS)
val setResourceInformationMethod =
- resource.getClass.getMethod("setResourceInformation", classOf[String],
resInfoClass)
+ try {
+ resource.getClass.getMethod("setResourceInformation", classOf[String],
resInfoClass)
+ } catch {
+ case e: NoSuchMethodException =>
+ throw new SparkException(
+ s"Cannot find $RESOURCE_INFO_CLASS.setResourceInformation. " +
+ "This is likely due to a jar conflict between different yarn
versions.", e)
Review comment:
I actually think that the most common case will be people trying to use with
the wrong version of the Hadoop libraries. The case you mention is only really
a problem for Spark devs...
So the message should say the Hadoop library in use does not support
resource requests, instead. (Spark devs should be smart enough to make the
association... there's a bunch of these kinds of conflicts that cause all sorts
of different exceptions.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
