cloud-fan commented on a change in pull request #25453: [WIP][SPARK-28730][SQL]
Configurable type coercion policy for table insertion
URL: https://github.com/apache/spark/pull/25453#discussion_r315543721
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala
##########
@@ -735,6 +735,39 @@ class InsertSuite extends QueryTest with
TestHiveSingleton with BeforeAndAfter
}
}
+ test("Throw exception on unsafe cast with strict casting policy") {
Review comment:
why duplicate the test here? This feature is not hive-specific and I think
it's good enough to create a test in sql/core `InsertSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
