Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4110#discussion_r23345050
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
@@ -377,6 +402,12 @@ private[ui] class StagePage(parent: StagesTab) extends
WebUIPage("stage") {
.map(m => s"${Utils.bytesToString(m.bytesWritten)}")
.getOrElse("")
+ val maybeShuffleReadBlockedTime =
metrics.flatMap(_.shuffleReadMetrics).map(_.fetchWaitTime)
+ val shuffleReadBlockedTimeSortable =
maybeShuffleReadBlockedTime.map(_.toString).getOrElse("")
+ val shuffleReadBlockedTimeReadable = maybeShuffleReadBlockedTime.map{
--- End diff --
_Suuuuper_ nitpicky style nit, but I'd put a space before this `{`.
However, I think you can just write this whole thing as a one-liner:
```scala
val shuffleReadBlockedTimeReadable =
maybeShuffleReadBlockedTime.map(UIUtils.formatDuration).getOrElse("")
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
