rdblue commented on a change in pull request #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#discussion_r315820103
########## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSuite.scala ########## @@ -38,8 +37,7 @@ class DataSourceV2SQLSuite extends QueryTest with SharedSparkSession with Before import org.apache.spark.sql.catalog.v2.CatalogV2Implicits._ - private val orc2 = classOf[OrcDataSourceV2].getName - private val v2Source = classOf[FakeV2Provider].getName + private val v2Format = classOf[FakeV2Provider].getName Review comment: Why rename `v2Source` to `v2Format`? That introduces several unnecessary changes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
