maropu commented on a change in pull request #25453: [SPARK-28730][SQL] Configurable type coercion policy for table insertion URL: https://github.com/apache/spark/pull/25453#discussion_r315959198
########## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DataSourceV2AnalysisSuite.scala ########## @@ -111,6 +115,20 @@ case class TestRelationAcceptAnySchema(output: Seq[AttributeReference]) } abstract class DataSourceV2AnalysisSuite extends AnalysisTest { + + override def getAnalyzer(caseSensitive: Boolean): Analyzer = { + val conf = new SQLConf() + .copy(SQLConf.CASE_SENSITIVE -> caseSensitive) + .copy(SQLConf.STORE_ASSIGNMENT_POLICY -> StoreAssignmentPolicy.STRICT) + val catalog = new SessionCatalog(new InMemoryCatalog, FunctionRegistry.builtin, conf) + catalog.createDatabase( + CatalogDatabase("default", "", new URI("loc"), Map.empty), Review comment: how about creating a temporary dir for loc? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org