zhengruifeng edited a comment on issue #25383: [SPARK-13677][ML] Implement Tree-Based Feature Transformation for ML URL: https://github.com/apache/spark/pull/25383#issuecomment-523272292 @srowen I make extra modifications, which move `setLeafCol` into a superclass. I am looking into the hierarchy of both py and scala sides, and found that in many places some setter are defined in both `Estimator` and `Model`, however there are still some places which put common setters in the corresponding param trait. I prefer the latter method, and suggest we may move common setters into superclasses in the future.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
