Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/4149#discussion_r23348685
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/JobGenerator.scala
---
@@ -238,13 +238,16 @@ class JobGenerator(jobScheduler: JobScheduler)
extends Logging {
/** Clear DStream metadata for the given `time`. */
private def clearMetadata(time: Time) {
ssc.graph.clearMetadata(time)
- jobScheduler.receiverTracker.cleanupOldMetadata(time -
graph.batchDuration)
// If checkpointing is enabled, then checkpoint,
// else mark batch to be fully processed
if (shouldCheckpoint) {
eventActor ! DoCheckpoint(time)
} else {
+ // If no checkpointing to be done, delete received block information
right now,
+ // else postpone until checkpoint written (better guarantees)
--- End diff --
so after talking - the part that I was confused about was how to interpret
"(better guarantees)". It wasn't clear what this refers to. Maybe just remove
this? I think you are just trying to say that overall, checkpointing offers
better guarentees.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
