ueshin commented on a change in pull request #24232: [SPARK-27297] [SQL] Add
higher order functions to scala API
URL: https://github.com/apache/spark/pull/24232#discussion_r315992363
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala
##########
@@ -1917,19 +1921,33 @@ class DataFrameFunctionsSuite extends QueryTest with
SharedSparkSession {
null
).toDF("i")
+ // transform(i, x -> x + 1)
+ val resA = Seq(
+ Row(Seq(2, 10, 9, 8)),
+ Row(Seq(6, 9, 10, 8, 3)),
+ Row(Seq.empty),
+ Row(null))
+
+ // transform(i, (x, i) -> x + i)
+ val resB = Seq(
+ Row(Seq(1, 10, 10, 10)),
+ Row(Seq(5, 9, 11, 10, 6)),
+ Row(Seq.empty),
+ Row(null))
+
def testArrayOfPrimitiveTypeNotContainsNull(): Unit = {
- checkAnswer(df.selectExpr("transform(i, x -> x + 1)"),
- Seq(
- Row(Seq(2, 10, 9, 8)),
- Row(Seq(6, 9, 10, 8, 3)),
- Row(Seq.empty),
- Row(null)))
- checkAnswer(df.selectExpr("transform(i, (x, i) -> x + i)"),
- Seq(
- Row(Seq(1, 10, 10, 10)),
- Row(Seq(5, 9, 11, 10, 6)),
- Row(Seq.empty),
- Row(null)))
+ checkAnswer(df.selectExpr("transform(i, x -> x + 1)"), resA)
+ checkAnswer(df.selectExpr("transform(i, (x, i) -> x + i)"), resB)
+
+ checkAnswer(df.select(transform(col("i"), x => x + 1)), resA)
+ checkAnswer(df.select(transform(col("i"), (x, i) => x + i)), resB)
+
+ checkAnswer(df.select(transform(col("i"), new JFunc {
+ def call(x: Column) = x + 1
+ })), resA)
+ checkAnswer(df.select(transform(col("i"), new JFunc2 {
+ def call(x: Column, i: Column) = x + i
+ })), resB)
Review comment:
The Java API tests you added to `DataFrameFunctionsSuite` are not useful.
Please move them to `JavaDataFrameSuite` or create
`JavaDataFrameFunctionsSuite` with lambda expressions as users usually do like
above and see what happens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
