dbaliafroozeh opened a new pull request #25534: [SPARK-28835][SQL] Improve 
canonicalize API
URL: https://github.com/apache/spark/pull/25534
 
 
   ### What changes were proposed in this pull request?
   This PR improves the `canonicalize` API by removing the method `def 
canonicalize(attrs: AttributeSeq): PlanExpression[T]` in `PlanExpression` and 
taking care of normalizing expressions in `QueryPlan`. 
   
   ### Why are the changes needed?
   `Expression` has already a `canonicalized` method and having the 
`canonicalize` method in `PlanExpression` is confusing.
   
   
   ### Does this PR introduce any user-facing change?
   Removes the `canonicalize` plan from `PlanExpression`. Also renames the 
`normalizeExprId` to `normalizeExpressions` in query plan.
   
   ### How was this patch tested?
   This PR is a refactoring and passes the existing tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to