cloud-fan commented on a change in pull request #24759: [SPARK-27395][SQL][WIP]
Improve EXPLAIN command
URL: https://github.com/apache/spark/pull/24759#discussion_r316166559
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -102,6 +103,10 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]]
extends Product {
tags.get(tag).map(_.asInstanceOf[T])
}
+ def removeTag[T](tag: TreeNodeTag[T]): Unit = {
Review comment:
super nit: to be consistent with other two names, how about `unsetTagValue`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
