sarutak commented on a change in pull request #25487: [SPARK-28769][CORE]
Improve warning message of BarrierExecutionMode when required slots > maximum
slots
URL: https://github.com/apache/spark/pull/25487#discussion_r316308265
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/BarrierJobAllocationFailed.scala
##########
@@ -33,7 +33,9 @@ private[spark] class
BarrierJobRunWithDynamicAllocationException
extends BarrierJobAllocationFailed(
BarrierJobAllocationFailed.ERROR_MESSAGE_RUN_BARRIER_WITH_DYN_ALLOCATION)
-private[spark] class BarrierJobSlotsNumberCheckFailed
+private[spark] class BarrierJobSlotsNumberCheckFailed(
Review comment:
I think it's difficult to know from DAGScheduler which barrier stage in a
job requires more slots. So a stage which requires more slots need to tell that
to DAGScheduler by passing back that in the message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
