Github user WangTaoTheTonic commented on a diff in the pull request:
https://github.com/apache/spark/pull/4129#discussion_r23357881
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/SparkDeploySchedulerBackend.scala
---
@@ -40,6 +40,14 @@ private[spark] class SparkDeploySchedulerBackend(
var registrationDone = false
val maxCores = conf.getOption("spark.cores.max").map(_.toInt)
+ val coreNumPerTask = {
+ val corePerTask = conf.getInt("spark.task.cpus", 1)
+ if (corePerTask < 1) {
+ throw new IllegalArgumentException(
+ s"spark.task.cpus is set to an invalid value $corePerTask")
+ }
+ corePerTask
+ }
--- End diff --
Is `corePerTask ` necessary? Why don't just assign
`conf.getInt("spark.task.cpus", 1)` to `coreNumPerTask `?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
