Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4032#discussion_r23361989
  
    --- Diff: 
streaming/src/test/scala/org/apache/spark/streaming/ReceivedBlockTrackerSuite.scala
 ---
    @@ -82,11 +82,6 @@ class ReceivedBlockTrackerSuite
         receivedBlockTracker.allocateBlocksToBatch(2)
         receivedBlockTracker.getBlocksOfBatchAndStream(2, streamId) shouldBe 
empty
     
    -    // Verify that batch 2 cannot be allocated again
    --- End diff --
    
    Please add test to verify that `allocateBlocksToBatch(x)` where x<=2 does 
nothing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to