cloud-fan commented on issue #25507: [SPARK-28667][SQL] Support InsertInto through the V2SessionCatalog URL: https://github.com/apache/spark/pull/25507#issuecomment-523901465 The change LGTM but the tests look a little messy now. What are the dimensions we want to test? From a quick look seems we want to test table insertion with 1. SQL API or DataFrameWriter API 2. with or without v2 session catalog 3. the table has v1 write fallback capability or not I expect to see a base testing trait with test cases, and a few concrete test suites which extend the base testing trait and set up different dimensions. But seems it's not the case here.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
