mgaido91 commented on a change in pull request #25461: [SPARK-28741][SQL]Throw
exceptions when casting to integers causes overflow
URL: https://github.com/apache/spark/pull/25461#discussion_r316695473
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/numerics.scala
##########
@@ -17,9 +17,11 @@
package org.apache.spark.sql.types
-import scala.math.Numeric.{ByteIsIntegral, IntIsIntegral, LongIsIntegral,
ShortIsIntegral}
+import scala.math.Numeric._
import scala.math.Ordering
+import org.apache.spark.sql.types.Decimal.DecimalIsConflicted
Review comment:
nit: I am wondering about moving it here...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
