Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4055#discussion_r23367928
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Task.scala ---
@@ -106,7 +106,22 @@ private[spark] abstract class Task[T](val stageId:
Int, var partitionId: Int) ex
if (interruptThread && taskThread != null) {
taskThread.interrupt()
}
- }
+ }
+
+ override def hashCode(): Int = {
+ val state = Seq(stageId, partitionId)
+ state.map(_.hashCode()).foldLeft(0)((a, b) => 31 * a + b)
+ }
+
+ def canEqual(other: Any): Boolean = other.isInstanceOf[Task[T]]
+
+ override def equals(other: Any): Boolean = other match {
+ case that: Task[_] =>
+ (that canEqual this) &&
--- End diff --
`that` is already a `Task` here; is the `canEqual` method adding anything?
the check has no dependency on the generic type `T`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
