brkyvz commented on issue #25507: [SPARK-28667][SQL] Support InsertInto through the V2SessionCatalog URL: https://github.com/apache/spark/pull/25507#issuecomment-523964801 Thanks @cloud-fan . Yeah, the tests got a bit out of control. (I'm fine with just copy pasting at this point too). The dimensions are as follows: ``` +------------------------------------+-----+-----------+----------------+--------------------+ | Suite | SQL | DataFrame | SessionCatalog | Dynamic Overwrites | +------------------------------------+-----+-----------+----------------+--------------------+ | DSV2DataFrameSuite | | x | | x | | DSV2DataFrameSessionCatalogSuite | | x | x | x | | DSV2SQLSuite | x | | | x | | DSV2SQLSessionCatalogSuite | x | | x | x | | V1WriteFallbackSuite | | | | | | V1WriteFallbackSessionCatalogSuite | x | | x | | +------------------------------------+-----+-----------+----------------+--------------------+ ``` V1WriteFallback cannot support DynamicOverwrites, so we want to check that that's not supported. Preferably, we would test DataFrames through the V1FallbackSuite as well, but considering that we have DSV2SQL and DSV2DataFrame suites already testing that, I'm just going to assume it works there. We already have those base traits by the way: - SessionCatalogTest - InsertIntoSQLTests Happy to refactor the tests to make it more understandable.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
