zsxwing commented on a change in pull request #25488: [SPARK-28025][SS] Fix
FileContextBasedCheckpointFileManager leaking crc files
URL: https://github.com/apache/spark/pull/25488#discussion_r316864528
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CheckpointFileManager.scala
##########
@@ -327,12 +327,14 @@ class FileContextBasedCheckpointFileManager(path: Path,
hadoopConf: Configuratio
override def renameTempFile(srcPath: Path, dstPath: Path,
overwriteIfPossible: Boolean): Unit = {
import Options.Rename._
fc.rename(srcPath, dstPath, if (overwriteIfPossible) OVERWRITE else NONE)
+ mayRemoveCrcFile(srcPath)
}
override def delete(path: Path): Unit = {
try {
fc.delete(path, true)
+ mayRemoveCrcFile(path)
Review comment:
Looks like org.apache.hadoop.fs.ChecksumFs.delete handles the file deletion
correctly, so we don't need this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
