imback82 commented on a change in pull request #25247: [SPARK-28319][SQL]
Implement SHOW TABLES for Data Source V2 Tables
URL: https://github.com/apache/spark/pull/25247#discussion_r316918976
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSuite.scala
##########
@@ -482,6 +482,8 @@ class DataSourceV2SQLSuite extends QueryTest with
SharedSparkSession with Before
val rdd = sparkContext.parallelize(table.asInstanceOf[InMemoryTable].rows)
checkAnswer(spark.internalCreateDataFrame(rdd, table.schema),
spark.table("source"))
+
+ spark.sql("DROP TABLE table_name")
Review comment:
Ah, my mistake. This can be removed, but the `DROP TABLE` below is still
valid.
For the test below, when the table `table_name` is created, V1 catalog
(`SessionCatalog`) is used via `sparkSession.sessionState.catalog`. So, it
cannot be reset from `spark.sessionState.catalogManager.reset()`.
I think `spark.sessionState.catalog.reset()` is a better way to do in
`after`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
