HeartSaVioR commented on a change in pull request #25488: [SPARK-28025][SS] Fix
FileContextBasedCheckpointFileManager leaking crc files
URL: https://github.com/apache/spark/pull/25488#discussion_r316922449
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CheckpointFileManager.scala
##########
@@ -343,5 +345,17 @@ class FileContextBasedCheckpointFileManager(path: Path,
hadoopConf: Configuratio
case _: LocalFs | _: RawLocalFs => true // LocalFs = RawLocalFs +
ChecksumFs
case _ => false
}
+
+ private def mayRemoveCrcFile(path: Path): Unit = {
+ val checksumFile = new Path(path.getParent, s".${path.getName}.crc")
Review comment:
Nice finding! HDFS-14762 looks odd but we have to live with it. The
suggestion looks great.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
