Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/4142#issuecomment-71055700
  
    Hi @redbaron ,
    
    > IMHO Spark should mimic what Hadoop MR is doing, which is building a 
Configuration object and then serializing into xml
    
    That has the limitation of not loading config data from files that the 
Configuration object you chose do not load. For example, if you're going to run 
a job that uses a HiveContext, you might want to also use hive-site.xml, as 
yourself mentioned in your comment. My patch covers that, since if you point 
`HADOOP_CONF_DIR` at a Hive config directory, it will ship that file and all 
should work.
    
    > Copying files verbatim from the directory leads to not being able to 
override hadoop config params via "-D=" switch
    
    If you're talking about the `-D` switch for the JVM, then that's already 
covered. `--driver-java-options` is reflected in the AM when running in cluster 
mode. There's a similar option for client mode, in case you also need that for 
the client-mode AM.
    
    Feels to me like my approach covers your concerns.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to