wangyum opened a new pull request #25567: [SPARK-28527][SQL][TEST] Re-run all 
the tests in SQLQueryTestSuite via Thrift Server
URL: https://github.com/apache/spark/pull/25567
 
 
   
   ### What changes were proposed in this pull request?
   This PR build a test framework that directly re-run all the tests in 
`SQLQueryTestSuite` via Thrift Server. But it's a little different from 
`SQLQueryTestSuite`:
   1. Can not support [UDF 
testing](https://github.com/apache/spark/blob/44e607e9213bdceab970606fb15292db2fe157c2/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala#L293-L297).
   2. Can not support `DESC` command and `SHOW` command because 
`SQLQueryTestSuite` [formatted the 
output](https://github.com/apache/spark/blob/1882912cca4921d3d8c8632b3bb34e69e8119791/sql/core/src/main/scala/org/apache/spark/sql/execution/HiveResult.scala#L38-L50.).
   
   When building this framework, found two bug:
   [SPARK-28624](https://issues.apache.org/jira/browse/SPARK-28624): 
`make_date` is inconsistent when reading from table
   [SPARK-28611](https://issues.apache.org/jira/browse/SPARK-28611): 
Histogram's height is different
   
   found two features that ThriftServer can not support:
   [SPARK-28636](https://issues.apache.org/jira/browse/SPARK-28636): 
ThriftServer can not support decimal type with negative scale
   [SPARK-28637](https://issues.apache.org/jira/browse/SPARK-28637): 
ThriftServer can not support interval type
   
   Also, found two inconsistent behavior:
   [SPARK-28620](https://issues.apache.org/jira/browse/SPARK-28620): Double 
type returned for float type in Beeline/JDBC
   [SPARK-28619](https://issues.apache.org/jira/browse/SPARK-28619):  The 
golden result file is different when tested by `bin/spark-sql`
   
   
   ### Why are the changes needed?
   
   Improve the overall test coverage for Thrift Server. 
   
   
   ### Does this PR introduce any user-facing change?
   No
   
   
   ### How was this patch tested?
   N/A
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to