Github user MattWhelan commented on the pull request:
https://github.com/apache/spark/pull/4165#issuecomment-71107518
@vanzin
There needs to be some locking. The 1.6 version of loadClass is simply a
synchronized method (on 'this'). That's a viable alternative, and the way I'll
do in in 1.6, since it's likely that 1.7 isn't an option. I haven't thought
through the deadlock scenario in this context; I'm not sure whether it applies.
I don't know what 1.7's fallback is for non-registered CLs. The docs imply
that it's not better, but that 1.7 can still support 1.6 CLs, so it's not the
end of the world.
The 1.6 way has the nice property that you could implement it entirely in
Scala though. Probably even as a trait.
See http://www.ibm.com/developerworks/java/library/j-dclp4/index.html for
more on CL deadlocks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
